Issue 1062123003: Support JavaScriptCore stack traces.

Issue 1062123003: Support JavaScriptCore stack traces. (Closed)

Created:
5 years, 8 months ago by nweiz

Modified:
5 years, 8 months ago

Reviewers:
kevmoo

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/stack_trace@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Support JavaScriptCore stack traces. R=kevmoo@google.com Committed: https://github.com/dart-lang/stack_trace/commit/c79e8c9137906047227a84e5f3607be439bc5758

Patch Set 2 : Better implementation #

Total comments: 2

Patch Set 3 : Code review changes #

Created: 5 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+31 lines, -1 line)			Patch
M	CHANGELOG.md	View	1	1 chunk	+5 lines, -0 lines	0 comments	Download
M	lib/src/frame.dart	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download
M	lib/src/trace.dart	View	1 2	2 chunks	+5 lines, -0 lines	0 comments	Download
M	pubspec.yaml	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	test/trace_test.dart	View	1	1 chunk	+17 lines, -0 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

nweiz

On 2015/04/13 23:06:56, kevmoo wrote: > lgtm PTAL I realized that the stack traces were ...

5 years, 8 months ago (2015-04-13 23:22:32 UTC) #3

kevmoo

LGTM - except extra print statement? https://codereview.chromium.org/1062123003/diff/20001/lib/src/trace.dart File lib/src/trace.dart (right): https://codereview.chromium.org/1062123003/diff/20001/lib/src/trace.dart#newcode133 lib/src/trace.dart:133: print(JSON.encode(trace)); Oops?

5 years, 8 months ago (2015-04-13 23:25:47 UTC) #4

nweiz

https://codereview.chromium.org/1062123003/diff/20001/lib/src/trace.dart File lib/src/trace.dart (right): https://codereview.chromium.org/1062123003/diff/20001/lib/src/trace.dart#newcode133 lib/src/trace.dart:133: print(JSON.encode(trace)); On 2015/04/13 23:25:47, kevmoo wrote: > Oops? Done.

5 years, 8 months ago (2015-04-13 23:27:19 UTC) #6

nweiz

5 years, 8 months ago (2015-04-13 23:27:28 UTC) #7

Message was sent while issue was closed.

Committed patchset #3 (id:40001) manually as
c79e8c9137906047227a84e5f3607be439bc5758 (presubmit successful).

Expand Messages | Collapse Messages