Issue 106193003: Cleanup VM service

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 106193003: Cleanup VM service (Closed)

Created:
7 years ago by Cutch

Modified:
7 years ago

Reviewers:
Jacob, siva

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Cleanup VM service R=jacobr@google.com Committed: https://code.google.com/p/dart/source/detail?r=30926

Patch Set 3 : #

Created: 7 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+33 lines, -39 lines)			Patch
M	runtime/bin/vmservice/running_isolates.dart	View	1	1 chunk	+4 lines, -2 lines	0 comments	Download
M	runtime/bin/vmservice/server.dart	View	1	2 chunks	+15 lines, -19 lines	0 comments	Download
M	runtime/bin/vmservice/service_request.dart	View		2 chunks	+2 lines, -1 line	0 comments	Download
M	runtime/bin/vmservice/vmservice.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/bin/vmservice/vmservice_dartium.dart	View		1 chunk	+9 lines, -14 lines	0 comments	Download
M	runtime/bin/vmservice_impl.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	tests/standalone/vmservice/unknown_command_test.dart	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Jacob

lgtm https://codereview.chromium.org/106193003/diff/1/runtime/bin/vmservice/server.dart File runtime/bin/vmservice/server.dart (right): https://codereview.chromium.org/106193003/diff/1/runtime/bin/vmservice/server.dart#newcode16 runtime/bin/vmservice/server.dart:16: request.response.headers.contentType = jsonContentType; use cascades request.response..headers.contentType = jsonContentType ...

7 years ago (2013-12-06 01:52:21 UTC) #2

Message was sent while issue was closed.

Committed patchset #3 manually as r30926 (presubmit successful).

Expand Messages | Collapse Messages

Issue 106193003: Cleanup VM service (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Messages