Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(292)

Issue 1061403002: Better way of fixing attribute_changed_callback_test, doesn't require a timer (Closed)

Created:
5 years, 8 months ago by Alan Knight
Modified:
5 years, 8 months ago
Reviewers:
terry
CC:
reviews_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Better way of fixing attribute_changed_callback_test, doesn't require a timer BUG= Committed: https://code.google.com/p/dart/source/detail?r=44946

Patch Set 1 #

Patch Set 2 : Removing leftover async keyword #

Patch Set 3 : ... and leftover timer #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -7 lines) Patch
M tests/html/custom/attribute_changed_callback_test.dart View 1 2 2 chunks +16 lines, -7 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
Alan Knight
TBR
5 years, 8 months ago (2015-04-07 20:52:44 UTC) #2
Alan Knight
5 years, 8 months ago (2015-04-07 20:53:00 UTC) #3
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as 44946 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698