Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(576)

Issue 1061243003: Move CHA field back to Isolate, pending a permanent fix. (Closed)

Created:
5 years, 8 months ago by koda
Modified:
5 years, 8 months ago
CC:
reviews_dartlang.org, vm-dev_dartlang.org, siva, Florian Schneider
Visibility:
Public.

Description

Move CHA field back to Isolate, pending a permanent fix. Since the Thread structure is currently cleared on Enter/ExitIsolate, there is a risk that CHA is cleared if an embedder callback executes during compilation and switches/spawns isolates. This CL eliminates that risk. However, Isolate is still not a good long-term place for CHA, since it doesn't fit with a concurrent compilation model. Issue 23153 tracks the work towards a permanent solution that couples its life cycle with compilation. R=fschneider@google.com, iposva@google.com Committed: https://code.google.com/p/dart/source/detail?r=45121

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -6 lines) Patch
M runtime/vm/isolate.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
M runtime/vm/isolate.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M runtime/vm/thread.h View 1 1 chunk +5 lines, -6 lines 0 comments Download
M runtime/vm/thread.cc View 1 chunk +11 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
koda
5 years, 8 months ago (2015-04-09 20:20:02 UTC) #1
koda
Please note that, if possible, I'd like to get this into tomorrow's full push for ...
5 years, 8 months ago (2015-04-09 20:26:52 UTC) #2
Ivan Posva
LGTM -ip
5 years, 8 months ago (2015-04-10 07:04:07 UTC) #3
Florian Schneider
lgtm
5 years, 8 months ago (2015-04-10 09:09:02 UTC) #5
koda
5 years, 8 months ago (2015-04-13 21:02:02 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as r45121 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698