Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1061033005: Remove profiler signal handler on shutdown (Closed)

Created:
5 years, 8 months ago by Cutch
Modified:
5 years, 8 months ago
Reviewers:
siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Remove profiler signal handler on shutdown BUG=https://github.com/domokit/mojo/issues/79 R=asiva@google.com Committed: https://code.google.com/p/dart/source/detail?r=44943

Patch Set 1 #

Patch Set 2 : #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+70 lines, -9 lines) Patch
M runtime/vm/signal_handler.h View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/vm/signal_handler_android.cc View 1 chunk +13 lines, -3 lines 2 comments Download
M runtime/vm/signal_handler_linux.cc View 1 chunk +13 lines, -3 lines 0 comments Download
M runtime/vm/signal_handler_macos.cc View 1 chunk +13 lines, -3 lines 0 comments Download
M runtime/vm/signal_handler_win.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M runtime/vm/thread_interrupter.h View 1 chunk +2 lines, -0 lines 0 comments Download
M runtime/vm/thread_interrupter.cc View 1 chunk +1 line, -0 lines 2 comments Download
M runtime/vm/thread_interrupter_android.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M runtime/vm/thread_interrupter_linux.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M runtime/vm/thread_interrupter_macos.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M runtime/vm/thread_interrupter_win.cc View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Cutch
5 years, 8 months ago (2015-04-06 23:28:38 UTC) #2
siva
LGTM with couple of comments. https://codereview.chromium.org/1061033005/diff/20001/runtime/vm/signal_handler_android.cc File runtime/vm/signal_handler_android.cc (right): https://codereview.chromium.org/1061033005/diff/20001/runtime/vm/signal_handler_android.cc#newcode103 runtime/vm/signal_handler_android.cc:103: } The normal protocol ...
5 years, 8 months ago (2015-04-07 18:18:08 UTC) #3
Cutch
Committed patchset #2 (id:20001) manually as 44943 (presubmit successful).
5 years, 8 months ago (2015-04-07 18:33:14 UTC) #4
Cutch
5 years, 8 months ago (2015-04-07 18:35:56 UTC) #5
Message was sent while issue was closed. 
https://codereview.chromium.org/1061033005/diff/20001/runtime/vm/signal_handl...
File runtime/vm/signal_handler_android.cc (right):

https://codereview.chromium.org/1061033005/diff/20001/runtime/vm/signal_handl...
runtime/vm/signal_handler_android.cc:103: }
On 2015/04/07 18:18:07, siva wrote:
> The normal protocol is to remember the old action and restore it when the new
> action is removed.
> 
> The new action handler if it does not have any action for the signal should
call
> the old action handler if it is not SIG_IGN. In the profiler case this is
> probably not needed as you handle all SIGPROF signals.

The default SIGPROF handler terminates the process
(http://man7.org/linux/man-pages/man7/signal.7.html)

https://codereview.chromium.org/1061033005/diff/20001/runtime/vm/thread_inter...
File runtime/vm/thread_interrupter.cc (right):

https://codereview.chromium.org/1061033005/diff/20001/runtime/vm/thread_inter...
runtime/vm/thread_interrupter.cc:317: RemoveSignalHandler();
On 2015/04/07 18:18:07, siva wrote:
> Instead of a per OS RemoveSignalHandler() implementation why not just call
> SignalHandler::Remove() here?

SignalHandler::Remove() on Windows is UNREACHABLE().

Powered by Google App Engine
This is Rietveld 408576698