Issue 1060783002: Mostly fix signal-forwarding for "pub run".

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1060783002: Mostly fix signal-forwarding for "pub run". (Closed)

Created:
5 years, 8 months ago by nweiz

Modified:
5 years, 8 months ago

Reviewers:
Bob Nystrom

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Target Ref:
refs/remotes/git-svn

Visibility:
Public.

More Reviews

Description

Mostly fix signal-forwarding for "pub run". When the user presses Control-C on the terminal, it sends SIGINT to all processes in the process tree. However, this is *not* the case for other signals or signals sent via other means. As a compromise, "pub run" now manually forwards all signals other than SIGINT. R=rnystrom@google.com Committed: https://code.google.com/p/dart/source/detail?r=44902

Patch Set 1 #

Created: 5 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+21 lines, -18 lines)			Patch
M	sdk/lib/_internal/pub/lib/src/executable.dart	View	4 chunks	+19 lines, -11 lines	0 comments	Download
M	sdk/lib/_internal/pub/test/run/forwards_signal_posix_test.dart	View	2 chunks	+0 lines, -2 lines	0 comments	Download
M	sdk/lib/_internal/pub/test/run/forwards_signal_windows_test.dart	View	2 chunks	+2 lines, -5 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

nweiz

5 years, 8 months ago (2015-04-04 00:31:22 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as 44902 (presubmit successful).

Expand Messages | Collapse Messages