Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(546)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1060713005: rename completion computer to contributor (Closed)

Created:
5 years, 8 months ago by danrubel
Modified:
5 years, 8 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

rename completion computer to contributor * this will be followed by a separate CL that renames related files BUG= R=scheglov@google.com Committed: https://code.google.com/p/dart/source/detail?r=44918

Patch Set 1 #

Patch Set 2 : merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+128 lines, -127 lines) Patch
M pkg/analysis_server/lib/src/services/completion/arglist_computer.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M pkg/analysis_server/lib/src/services/completion/combinator_computer.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M pkg/analysis_server/lib/src/services/completion/completion_manager.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/analysis_server/lib/src/services/completion/dart_completion_cache.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/analysis_server/lib/src/services/completion/dart_completion_manager.dart View 8 chunks +25 lines, -24 lines 0 comments Download
M pkg/analysis_server/lib/src/services/completion/imported_computer.dart View 3 chunks +5 lines, -5 lines 0 comments Download
M pkg/analysis_server/lib/src/services/completion/invocation_computer.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M pkg/analysis_server/lib/src/services/completion/keyword_computer.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M pkg/analysis_server/lib/src/services/completion/local_computer.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M pkg/analysis_server/lib/src/services/completion/local_declaration_visitor.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/services/completion/optype.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/services/completion/arglist_computer_test.dart View 1 chunk +4 lines, -4 lines 0 comments Download
M pkg/analysis_server/test/services/completion/combinator_computer_test.dart View 1 chunk +4 lines, -4 lines 0 comments Download
M pkg/analysis_server/test/services/completion/completion_computer_test.dart View 4 chunks +16 lines, -16 lines 0 comments Download
M pkg/analysis_server/test/services/completion/completion_test_util.dart View 22 chunks +27 lines, -27 lines 0 comments Download
M pkg/analysis_server/test/services/completion/imported_computer_test.dart View 7 chunks +12 lines, -12 lines 0 comments Download
M pkg/analysis_server/test/services/completion/invocation_computer_test.dart View 2 chunks +4 lines, -4 lines 0 comments Download
M pkg/analysis_server/test/services/completion/keyword_computer_test.dart View 2 chunks +4 lines, -4 lines 0 comments Download
M pkg/analysis_server/test/services/completion/local_computer_test.dart View 3 chunks +5 lines, -5 lines 0 comments Download
M pkg/analysis_server/test/services/completion/optype_test.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
danrubel
5 years, 8 months ago (2015-04-03 22:26:17 UTC) #2
scheglov
LGTM
5 years, 8 months ago (2015-04-05 04:39:59 UTC) #3
danrubel
5 years, 8 months ago (2015-04-06 17:25:32 UTC) #4
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as 44918 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698