Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(795)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1060713002: Allow packages up to 100MB. (Closed)

Created:
5 years, 8 months ago by Bob Nystrom
Modified:
5 years, 8 months ago
Reviewers:
nweiz
CC:
reviews_dartlang.org, sethladd, eseidel1
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Allow packages up to 100MB. BUG=https://code.google.com/p/dart/issues/detail?id=22935 R=nweiz@google.com Committed: https://code.google.com/p/dart/source/detail?r=44885

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -7 lines) Patch
M sdk/lib/_internal/pub/lib/src/validator/size.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M sdk/lib/_internal/pub/test/validator/size_test.dart View 1 chunk +4 lines, -4 lines 2 comments Download

Messages

Total messages: 5 (1 generated)
Bob Nystrom
This bumps the pub client app's package size limit up to 100MB from 10MB.
5 years, 8 months ago (2015-04-03 19:37:19 UTC) #2
nweiz
lgtm https://codereview.chromium.org/1060713002/diff/1/sdk/lib/_internal/pub/test/validator/size_test.dart File sdk/lib/_internal/pub/test/validator/size_test.dart (right): https://codereview.chromium.org/1060713002/diff/1/sdk/lib/_internal/pub/test/validator/size_test.dart#newcode30 sdk/lib/_internal/pub/test/validator/size_test.dart:30: integration('should consider a package invalid if it is ...
5 years, 8 months ago (2015-04-03 19:38:01 UTC) #3
Bob Nystrom
Committed patchset #1 (id:1) manually as 44885 (presubmit successful).
5 years, 8 months ago (2015-04-03 20:03:03 UTC) #4
Bob Nystrom
5 years, 8 months ago (2015-04-03 20:03:33 UTC) #5
Message was sent while issue was closed. 
https://codereview.chromium.org/1060713002/diff/1/sdk/lib/_internal/pub/test/...
File sdk/lib/_internal/pub/test/validator/size_test.dart (right):

https://codereview.chromium.org/1060713002/diff/1/sdk/lib/_internal/pub/test/...
sdk/lib/_internal/pub/test/validator/size_test.dart:30: integration('should
consider a package invalid if it is more than 100 MB', () {
On 2015/04/03 19:38:00, nweiz wrote:
> Long line.

Done.

Powered by Google App Engine
This is Rietveld 408576698