Issue 1060293002: Fix bug in dart2js async rewrite

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1060293002: Fix bug in dart2js async rewrite (Closed)

Created:
5 years, 8 months ago by sigurdm

Modified:
5 years, 8 months ago

Reviewers:
floitsch

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Target Ref:
refs/remotes/git-svn

Visibility:
Public.

More Reviews

Description

Fix bug in dart2js async rewrite In some cases where a transform of yield and await was not needed, the old nodes were reused - instead they should have been visited to allow renaming and rewrite of `this`. BUG= dartbug.com/23058 R=floitsch@google.com Committed: https://code.google.com/p/dart/source/detail?r=44933

Patch Set 1 #

Created: 5 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+26 lines, -19 lines)			Patch
	M	pkg/compiler/lib/src/js/rewrite_async.dart	View		3 chunks	+8 lines, -8 lines	0 comments	Download
	A +	tests/language/async_regression_23058_test.dart	View		1 chunk	+18 lines, -11 lines	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

sigurdm

5 years, 8 months ago (2015-04-07 12:07:18 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as 44933 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages