Issue 1060103002: Fix attribute_changed_callback_test to expect event delivery either synchronously or asynchronously

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1060103002: Fix attribute_changed_callback_test to expect event delivery either synchronously or asynchronously (Closed)

Created:
5 years, 8 months ago by Alan Knight

Modified:
5 years, 8 months ago

Reviewers:
terry

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Target Ref:
refs/remotes/git-svn

Visibility:
Public.

More Reviews

Description

Fix attribute_changed_callback_test to expect event delivery either synchronously or asynchronously BUG= R=terry@google.com Committed: https://code.google.com/p/dart/source/detail?r=44942

Patch Set 1 #

Total comments: 1

Created: 5 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -7 lines)			Patch
	M	tests/html/custom/attribute_changed_callback_test.dart	View		2 chunks	+10 lines, -5 lines	0 comments	Download
	M	tests/html/html.status	View		2 chunks	+1 line, -2 lines	1 comment	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

terry

LGTM just suggestion to track the feature. https://codereview.chromium.org/1060103002/diff/1/tests/html/html.status File tests/html/html.status (right): https://codereview.chromium.org/1060103002/diff/1/tests/html/html.status#newcode40 tests/html/html.status:40: custom/attribute_changed_callback_test/unsupported_on_polyfill: Fail ...

5 years, 8 months ago (2015-04-06 20:08:23 UTC) #3

Alan Knight

5 years, 8 months ago (2015-04-07 18:24:06 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as 44942 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages