Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(775)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1060063008: Add API for contributing to the index (Closed)

Created:
5 years, 8 months ago by Brian Wilkerson
Modified:
5 years, 8 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add API for contributing to the index R=scheglov@google.com Committed: https://code.google.com/p/dart/source/detail?r=45358

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+268 lines, -9 lines) Patch
A pkg/analysis_server/lib/analysis/index/index_core.dart View 1 chunk +181 lines, -0 lines 2 comments Download
A pkg/analysis_server/lib/analysis/index/index_dart.dart View 1 chunk +41 lines, -0 lines 0 comments Download
A + pkg/analysis_server/lib/plugin/index.dart View 1 chunk +7 lines, -7 lines 0 comments Download
M pkg/analysis_server/lib/src/plugin/server_plugin.dart View 8 chunks +39 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Brian Wilkerson
5 years, 8 months ago (2015-04-22 17:03:24 UTC) #2
scheglov
LGTM https://codereview.chromium.org/1060063008/diff/1/pkg/analysis_server/lib/analysis/index/index_core.dart File pkg/analysis_server/lib/analysis/index/index_core.dart (right): https://codereview.chromium.org/1060063008/diff/1/pkg/analysis_server/lib/analysis/index/index_core.dart#newcode128 pkg/analysis_server/lib/analysis/index/index_core.dart:128: * Instances of the class [Location] represent a ...
5 years, 8 months ago (2015-04-22 19:34:12 UTC) #3
Brian Wilkerson
https://codereview.chromium.org/1060063008/diff/1/pkg/analysis_server/lib/analysis/index/index_core.dart File pkg/analysis_server/lib/analysis/index/index_core.dart (right): https://codereview.chromium.org/1060063008/diff/1/pkg/analysis_server/lib/analysis/index/index_core.dart#newcode128 pkg/analysis_server/lib/analysis/index/index_core.dart:128: * Instances of the class [Location] represent a location ...
5 years, 8 months ago (2015-04-22 20:11:11 UTC) #4
Brian Wilkerson
5 years, 8 months ago (2015-04-22 20:11:30 UTC) #5
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as 45358 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698