Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Issue 1059883002: pkg/test: silence analyzer about downcast (Closed)

Created:
5 years, 8 months ago by kevmoo
Modified:
5 years, 8 months ago
Reviewers:
nweiz
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/unittest.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M test/util/string_literal_iterator_test.dart View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
kevmoo
5 years, 8 months ago (2015-04-03 23:03:53 UTC) #2
nweiz
lgtm
5 years, 8 months ago (2015-04-03 23:07:45 UTC) #3
nweiz
lgtm lgtm
5 years, 8 months ago (2015-04-03 23:07:45 UTC) #4
kevmoo
5 years, 8 months ago (2015-04-03 23:09:34 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
a37947816f3b7679a2940a42c65baeafbf83ae74 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698