Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Issue 1059493002: Fixes bug in typed data read/write for floats and doubles. (Closed)

Created:
5 years, 8 months ago by zra
Modified:
5 years, 8 months ago
Reviewers:
Cutch, Ivan Posva
CC:
reviews_dartlang.org, ricow1, vm-dev_dartlang.org
Visibility:
Public.

Description

Fixes bug in typed data read/write for floats and doubles. When reading from a byte array as floats or doubles, perform the endianness correction before converting to a float or double rather than the other way around. This is to avoid floating point canonicalization changing the bytes before we put them in the right order. Unrelatedly, this change also adds armv5te as an architecture needing extra time for tests to correct an oversight in my last CL. R=iposva@google.com Committed: https://code.google.com/p/dart/source/detail?r=44871

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -30 lines) Patch
M runtime/lib/typed_data.dart View 1 5 chunks +19 lines, -26 lines 0 comments Download
M runtime/vm/method_recognizer.h View 2 chunks +4 lines, -4 lines 0 comments Download
M tools/testing/dart/runtime_configuration.dart View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
zra
5 years, 8 months ago (2015-04-02 17:46:30 UTC) #2
Ivan Posva
LGTM -ip
5 years, 8 months ago (2015-04-02 19:34:45 UTC) #3
zra
5 years, 8 months ago (2015-04-02 20:22:45 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as r44871 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698