Issue 1059443008: Revert "Remove an unused field from one of the CPS translation classes."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1059443008: Revert "Remove an unused field from one of the CPS translation classes." (Closed)

Created:
5 years, 8 months ago by Kevin Millikin (Google)

Modified:
5 years, 8 months ago

Reviewers:
asgerf

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Target Ref:
refs/remotes/git-svn

Visibility:
Public.

More Reviews

Description

Revert "Remove an unused field from one of the CPS translation classes." This reverts SVN revision 45168. The return value of IrBuilder.buildFunctionHeader is used in the JS backend for constructor type parameters. It should be possible to do it a different way but it's too tangled for a quick fix. BUG= Committed: https://code.google.com/p/dart/source/detail?r=45171

Patch Set 1 #

Created: 5 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -3 lines)			Patch
	M	pkg/compiler/lib/src/cps_ir/cps_ir_builder.dart	View		4 chunks	+9 lines, -3 lines	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Kevin Millikin (Google)

Committed patchset #1 (id:1) manually as 45171 (presubmit successful).

5 years, 8 months ago (2015-04-15 16:10:42 UTC) #3

Message was sent while issue was closed.

Oh well. lgtm

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages