Issue 23091. Fix for adding import prefix before string-interpolated identifier.

Issue 23091. Fix for adding import prefix before string-interpolated identifier.

R=paulberry@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=23091

Committed: https://code.google.com/p/dart/source/detail?r=44893

[Paul Berry, 2015-04-03 21:25:27]

https://codereview.chromium.org/1059133003/diff/1/pkg/analysis_server/lib/src...
File pkg/analysis_server/lib/src/services/refactoring/rename_import.dart
(right):

https://codereview.chromium.org/1059133003/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/services/refactoring/rename_import.dart:105: if
(node is SimpleIdentifier && node.parent is InterpolationExpression) {
I don't think this is quite right.  This if-test will pass both for the case of
renaming $x and for renaming ${x}.  Which means that ${x} will get incorrectly
renamed to ${{prefix.x}}.

[scheglov, 2015-04-03 21:33:28]

PTAL

https://codereview.chromium.org/1059133003/diff/1/pkg/analysis_server/lib/src...
File pkg/analysis_server/lib/src/services/refactoring/rename_import.dart
(right):

https://codereview.chromium.org/1059133003/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/services/refactoring/rename_import.dart:105: if
(node is SimpleIdentifier && node.parent is InterpolationExpression) {
On 2015/04/03 21:25:27, Paul Berry wrote:
> I don't think this is quite right.  This if-test will pass both for the case
of
> renaming $x and for renaming ${x}.  Which means that ${x} will get incorrectly
> renamed to ${{prefix.x}}.

Fixed.

[Paul Berry, 2015-04-03 21:57:19]

lgtm

[scheglov, 2015-04-03 21:59:07]

Committed patchset #2 (id:20001) manually as 44893 (presubmit successful).