Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(237)

Issue 1058643002: Tweak debugger safe point generation (Closed)

Created:
5 years, 8 months ago by hausner
Modified:
5 years, 8 months ago
Reviewers:
Ivan Posva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Tweak debugger safe point generation This change eliminates debugger safe points (DebugStepCheck calls) on variable assignments where the value is loaded from an internal variable. This fixes issues like the one reported in bug 22447 by eliminating some safe points from implicitly generated code that interfered with user code. To fully eliminate the root cause of this, we’d have to record the order in which safe points on a source line are executed. That’s for another day, month, year... R=iposva@google.com Committed: https://code.google.com/p/dart/source/detail?r=44847

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M runtime/vm/flow_graph_builder.cc View 1 1 chunk +4 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
hausner
5 years, 8 months ago (2015-04-01 22:22:22 UTC) #2
Ivan Posva
LGTM -ip
5 years, 8 months ago (2015-04-01 22:28:21 UTC) #3
hausner
5 years, 8 months ago (2015-04-01 22:31:49 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as r44847 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698