Issue 1058433003: "Redo "Avoid getInterceptor calls in cases were the interceptor would be constant if it were not `n…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1058433003: "Redo "Avoid getInterceptor calls in cases were the interceptor would be constant if it were not `n… (Closed)

Created:
5 years, 8 months ago by sra1

Modified:
5 years, 8 months ago

Reviewers:
floitsch

CC:
reviews_dartlang.org, Johnni Winther

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Target Ref:
refs/remotes/git-svn

Visibility:
Public.

More Reviews

Description

"Redo "Avoid getInterceptor calls in cases were the interceptor would be constant if it were not `null`." agains. TBR=floitsch@google.com Committed: https://code.google.com/p/dart/source/detail?r=44858

Patch Set 1 #

Patch Set 2 : #

Created: 5 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+133 lines, -39 lines)			Patch
M	pkg/compiler/lib/src/ssa/codegen.dart	View		1 chunk	+19 lines, -8 lines	0 comments	Download
M	pkg/compiler/lib/src/ssa/interceptor_simplifier.dart	View		3 chunks	+65 lines, -30 lines	0 comments	Download
M	pkg/compiler/lib/src/ssa/nodes.dart	View		1 chunk	+19 lines, -0 lines	0 comments	Download
M	tests/compiler/dart2js/analyze_unused_dart2js_test.dart	View	1	1 chunk	+5 lines, -1 line	0 comments	Download
A	tests/compiler/dart2js/interceptor_almost_constant_test.dart	View		1 chunk	+25 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

sra1

Committed patchset #2 (id:20001) manually as 44858 (presubmit successful).

5 years, 8 months ago (2015-04-02 02:59:54 UTC) #1

floitsch

5 years, 8 months ago (2015-04-07 10:39:30 UTC) #2

Message was sent while issue was closed.

LGTM.
Usually there are better ways to "use" unused functions. Not sure if it applies
here, though.
(And we should update the comment to explain where).

Expand Messages | Collapse Messages