Issue 1057793003: Fix missing annotations in script inset when first annotation is outside the subset of lines being …

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1057793003: Fix missing annotations in script inset when first annotation is outside the subset of lines being … (Closed)

Created:
5 years, 8 months ago by rmacnak

Modified:
5 years, 8 months ago

Reviewers:
Cutch

CC:
reviews_dartlang.org, turnidge, Cutch, vm-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Target Ref:
refs/remotes/git-svn

Visibility:
Public.

Fix missing annotations in script inset when first annotation is outside the subset of lines being displayed. R=johnmccutchan@google.com Committed: https://code.google.com/p/dart/source/detail?r=45326

Created: 5 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -0 lines)			Patch
	M	runtime/observatory/lib/src/elements/script_inset.dart	View		1 chunk	+10 lines, -0 lines	0 comments	Download

Total messages: 5 (1 generated)

rmacnak

We may also want flags on script-insets that say whether to include coverage/declarations/callsites. The current ...

5 years, 8 months ago (2015-04-22 00:32:53 UTC) #3

rmacnak

5 years, 8 months ago (2015-04-22 00:43:03 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as 45326 (presubmit successful).