Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Issue 1057753002: Redo "Avoid getInterceptor calls in cases were the interceptor would be constant if it were not `nu… (Closed)

Created:
5 years, 8 months ago by sra1
Modified:
5 years, 8 months ago
Reviewers:
floitsch
CC:
reviews_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Redo "Avoid getInterceptor calls in cases were the interceptor would be constant if it were not `null`." TBR=floitsch@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=44856

Patch Set 1 #

Patch Set 2 : fix assert fail #

Unified diffs Side-by-side diffs Delta from patch set Stats (+128 lines, -38 lines) Patch
M pkg/compiler/lib/src/ssa/codegen.dart View 1 chunk +19 lines, -8 lines 0 comments Download
M pkg/compiler/lib/src/ssa/interceptor_simplifier.dart View 3 chunks +65 lines, -30 lines 0 comments Download
M pkg/compiler/lib/src/ssa/nodes.dart View 1 1 chunk +19 lines, -0 lines 0 comments Download
A tests/compiler/dart2js/interceptor_almost_constant_test.dart View 1 chunk +25 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
sra1
Committed patchset #2 (id:20001) manually as 44856 (presubmit successful).
5 years, 8 months ago (2015-04-02 01:44:13 UTC) #2
floitsch
5 years, 8 months ago (2015-04-02 02:42:31 UTC) #3
Message was sent while issue was closed.
LGTM.

Powered by Google App Engine
This is Rietveld 408576698