Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1197)

Issue 1057513002: Also intialize methods inherited from mixin classes. (Closed)

Created:
5 years, 8 months ago by herhut
Modified:
5 years, 8 months ago
Reviewers:
floitsch, zarah, sra1
CC:
reviews_dartlang.org, zarah
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Added a regression test. #

Total comments: 4

Patch Set 3 : Comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+100 lines, -51 lines) Patch
M pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart View 2 chunks +0 lines, -15 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/old_emitter/setup_program_builder.dart View 1 2 4 chunks +71 lines, -36 lines 0 comments Download
A tests/compiler/dart2js_extra/23056_test.dart View 1 1 chunk +29 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
herhut
5 years, 8 months ago (2015-04-01 12:03:40 UTC) #1
zarah
LGTM w/ comments. https://codereview.chromium.org/1057513002/diff/20001/pkg/compiler/lib/src/js_emitter/old_emitter/setup_program_builder.dart File pkg/compiler/lib/src/js_emitter/old_emitter/setup_program_builder.dart (right): https://codereview.chromium.org/1057513002/diff/20001/pkg/compiler/lib/src/js_emitter/old_emitter/setup_program_builder.dart#newcode423 pkg/compiler/lib/src/js_emitter/old_emitter/setup_program_builder.dart:423: = mixinDeferredActionHelper(mixinPrototype, constructor.prototype); Long line. https://codereview.chromium.org/1057513002/diff/20001/pkg/compiler/lib/src/js_emitter/old_emitter/setup_program_builder.dart#newcode487 ...
5 years, 8 months ago (2015-04-01 12:56:52 UTC) #3
herhut
https://codereview.chromium.org/1057513002/diff/20001/pkg/compiler/lib/src/js_emitter/old_emitter/setup_program_builder.dart File pkg/compiler/lib/src/js_emitter/old_emitter/setup_program_builder.dart (right): https://codereview.chromium.org/1057513002/diff/20001/pkg/compiler/lib/src/js_emitter/old_emitter/setup_program_builder.dart#newcode423 pkg/compiler/lib/src/js_emitter/old_emitter/setup_program_builder.dart:423: = mixinDeferredActionHelper(mixinPrototype, constructor.prototype); On 2015/04/01 12:56:52, zarah wrote: > ...
5 years, 8 months ago (2015-04-01 13:14:02 UTC) #4
herhut
5 years, 8 months ago (2015-04-01 13:15:08 UTC) #5
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as 44832 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698