Cache the intermediate result of a div (or rem) operation on bigint and reuse if

Cache the intermediate result of a div (or rem) operation on bigint and reuse if
followed by rem (or div) with identical dividend and divisor.

Committed: https://code.google.com/p/dart/source/detail?r=44925

[regis, 2015-04-02 20:56:30]

regis@google.com changed reviewers:
+ srdjan@google.com

[srdjan, 2015-04-02 21:06:42]

LGTMwC

https://codereview.chromium.org/1057053002/diff/1/runtime/lib/bigint.dart
File runtime/lib/bigint.dart (right):

https://codereview.chromium.org/1057053002/diff/1/runtime/lib/bigint.dart#new...
runtime/lib/bigint.dart:976: if (_neg != a._neg && quo._used > 0) {
Use parentheses.

https://codereview.chromium.org/1057053002/diff/1/runtime/lib/bigint.dart#new...
runtime/lib/bigint.dart:992: !identical(a._digits, _lastDivisor_digits)) {
Factor out the test.

https://codereview.chromium.org/1057053002/diff/1/runtime/lib/bigint.dart#new...
runtime/lib/bigint.dart:1005: if (_neg && rem._used > 0) {
Use parentheses please

[regis, 2015-04-06 19:51:18]

Thanks!

https://codereview.chromium.org/1057053002/diff/1/runtime/lib/bigint.dart
File runtime/lib/bigint.dart (right):

https://codereview.chromium.org/1057053002/diff/1/runtime/lib/bigint.dart#new...
runtime/lib/bigint.dart:976: if (_neg != a._neg && quo._used > 0) {
On 2015/04/02 21:06:41, srdjan wrote:
> Use parentheses.

Done.

https://codereview.chromium.org/1057053002/diff/1/runtime/lib/bigint.dart#new...
runtime/lib/bigint.dart:992: !identical(a._digits, _lastDivisor_digits)) {
On 2015/04/02 21:06:41, srdjan wrote:
> Factor out the test.

I moved the test to _divRem.

https://codereview.chromium.org/1057053002/diff/1/runtime/lib/bigint.dart#new...
runtime/lib/bigint.dart:1005: if (_neg && rem._used > 0) {
On 2015/04/02 21:06:42, srdjan wrote:
> Use parentheses please

Done.

[regis, 2015-04-06 19:51:44]

Committed patchset #2 (id:20001) manually as r44925 (presubmit successful).