Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(475)

Issue 1056903002: Enable dart2js hints test. (Closed)

Created:
5 years, 8 months ago by scheglov
Modified:
5 years, 8 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Enable dart2js hints test. Type hierarchies are built completely now, so we don't have any additional warnings. R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=44859

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -16 lines) Patch
M pkg/analyzer/lib/src/task/dart.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/analyzer/test/src/task/dart_test.dart View 1 chunk +13 lines, -15 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
scheglov
5 years, 8 months ago (2015-04-02 15:30:13 UTC) #1
Brian Wilkerson
LGTM
5 years, 8 months ago (2015-04-02 16:00:06 UTC) #2
scheglov
5 years, 8 months ago (2015-04-02 16:09:23 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 44859 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698