Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(472)

Issue 1056233002: Mark all tests as skip on the browser. (Closed)

Created:
5 years, 8 months ago by nweiz
Modified:
5 years, 8 months ago
Reviewers:
kevmoo
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/test@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : Code review changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -3 lines) Patch
M .status View 1 1 chunk +6 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
nweiz
5 years, 8 months ago (2015-04-03 23:45:51 UTC) #1
kevmoo
https://codereview.chromium.org/1056233002/diff/1/.status File .status (right): https://codereview.chromium.org/1056233002/diff/1/.status#newcode31 .status:31: lib/*: SkipByDesign lib/? Don't you mean test/?
5 years, 8 months ago (2015-04-04 00:10:47 UTC) #2
nweiz
Code review changes
5 years, 8 months ago (2015-04-04 00:29:47 UTC) #3
nweiz
https://codereview.chromium.org/1056233002/diff/1/.status File .status (right): https://codereview.chromium.org/1056233002/diff/1/.status#newcode31 .status:31: lib/*: SkipByDesign On 2015/04/04 00:10:47, kevmoo wrote: > lib/? ...
5 years, 8 months ago (2015-04-04 00:29:54 UTC) #4
kevmoo
lgtm
5 years, 8 months ago (2015-04-04 00:44:59 UTC) #5
nweiz
5 years, 8 months ago (2015-04-06 19:38:50 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
2a3b95f4ebb4f22a3b60a98d81c8d535023aec22 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698