Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(311)

Issue 1056223002: Fix crash when posting a message to a send port with port id 0. (Closed)

Created:
5 years, 8 months ago by Cutch
Modified:
5 years, 8 months ago
Reviewers:
zra, turnidge
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Fix crash when posting a message to a send port with port id 0. BUG= R=zra@google.com Committed: https://code.google.com/p/dart/source/detail?r=44906

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -0 lines) Patch
M runtime/include/dart_api.h View 1 1 chunk +5 lines, -0 lines 0 comments Download
M runtime/vm/dart_api_impl.cc View 1 2 chunks +8 lines, -0 lines 0 comments Download
M runtime/vm/dart_api_impl_test.cc View 1 chunk +14 lines, -0 lines 0 comments Download
M runtime/vm/object.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M runtime/vm/port.cc View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Cutch
5 years, 8 months ago (2015-04-03 23:33:43 UTC) #2
zra
lgtm https://codereview.chromium.org/1056223002/diff/1/runtime/vm/dart_api_impl.cc File runtime/vm/dart_api_impl.cc (right): https://codereview.chromium.org/1056223002/diff/1/runtime/vm/dart_api_impl.cc#newcode1628 runtime/vm/dart_api_impl.cc:1628: if (port_id == ILLEGAL_PORT) { Should this go ...
5 years, 8 months ago (2015-04-04 05:03:48 UTC) #3
Cutch
https://codereview.chromium.org/1056223002/diff/1/runtime/vm/dart_api_impl.cc File runtime/vm/dart_api_impl.cc (right): https://codereview.chromium.org/1056223002/diff/1/runtime/vm/dart_api_impl.cc#newcode1628 runtime/vm/dart_api_impl.cc:1628: if (port_id == ILLEGAL_PORT) { On 2015/04/04 05:03:47, zra ...
5 years, 8 months ago (2015-04-05 19:06:09 UTC) #4
Cutch
Committed patchset #2 (id:20001) manually as 44906 (presubmit successful).
5 years, 8 months ago (2015-04-05 19:06:43 UTC) #5
turnidge
5 years, 8 months ago (2015-04-06 18:21:25 UTC) #7
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698