Issue 1055983003: guard against non-existant package directory

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1055983003: guard against non-existant package directory (Closed)

Created:
5 years, 8 months ago by danrubel

Modified:
5 years, 8 months ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Target Ref:
refs/remotes/git-svn

Visibility:
Public.

More Reviews

Description

guard against non-existant package directory BUG=dartbug.com/23073 R=brianwilkerson@google.com Committed: https://code.google.com/p/dart/source/detail?r=45417

Patch Set 2 : merge #

Created: 5 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -1 line)			Patch
	M	pkg/analysis_server/lib/src/context_manager.dart	View		1 chunk	+9 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Brian Wilkerson

LGTM, with or without the suggested change https://codereview.chromium.org/1055983003/diff/1/pkg/analysis_server/lib/src/context_manager.dart File pkg/analysis_server/lib/src/context_manager.dart (right): https://codereview.chromium.org/1055983003/diff/1/pkg/analysis_server/lib/src/context_manager.dart#newcode406 pkg/analysis_server/lib/src/context_manager.dart:406: Resource res ...

5 years, 8 months ago (2015-04-24 21:43:20 UTC) #3

danrubel

5 years, 8 months ago (2015-04-24 21:46:57 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as 45417 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Issue 1055983003: guard against non-existant package directory (Closed)

Description

Patch Set 1 #

Patch Set 2 : merge #

Messages