Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Issue 1055943004: Process outstanding events before making a new HTTP client request (Closed)

Created:
5 years, 8 months ago by Søren Gjesse
Modified:
5 years, 8 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Process outstanding events before making a new HTTP client request This re-applies r45127, which was reverted in r45129. The revert was due to a failing test which is re-written here to perform the separate steps in a deterministic order. Original change description: This fixes the issue of using a HTTP client connection from the connection pool which was closed and where the close indication has already been received by the event handler. This specifically fixes the 'pub get' issue where a long running constraint resolver would end with the error "Connection closed before full header was received" Retrying GET methods when the connection is closed after succesfuly sending (parts of) the request is still missing. R=lrn@google.com BUG=http://dartbug.com/21798 Committed: https://code.google.com/p/dart/source/detail?r=45313

Patch Set 1 #

Total comments: 1

Patch Set 2 : Addressed review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -20 lines) Patch
M sdk/lib/io/http_impl.dart View 1 1 chunk +5 lines, -1 line 0 comments Download
M tests/standalone/io/https_bad_certificate_client.dart View 3 chunks +11 lines, -10 lines 0 comments Download
M tests/standalone/io/https_bad_certificate_test.dart View 2 chunks +7 lines, -9 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Søren Gjesse
5 years, 8 months ago (2015-04-21 12:07:59 UTC) #1
Lasse Reichstein Nielsen
lgtm https://codereview.chromium.org/1055943004/diff/1/sdk/lib/io/http_impl.dart File sdk/lib/io/http_impl.dart (right): https://codereview.chromium.org/1055943004/diff/1/sdk/lib/io/http_impl.dart#newcode1886 sdk/lib/io/http_impl.dart:1886: return new Future(() => connect(new HttpException("No proxies given"))); ...
5 years, 8 months ago (2015-04-21 12:11:14 UTC) #2
Søren Gjesse
5 years, 8 months ago (2015-04-21 12:15:03 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 45313 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698