Issue 1055703005: Cleanup obsolete setter code

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1055703005: Cleanup obsolete setter code (Closed)

Created:
5 years, 8 months ago by hausner

Modified:
5 years, 8 months ago

Reviewers:
regis

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

Cleanup obsolete setter code Early on in Dart, it was ok to have a static getter and dynamic setter with the same name. This is no longer the case. Remove code that handles the obsolete case. R=regis@google.com Committed: https://code.google.com/p/dart/source/detail?r=45122

Created: 5 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+27 lines, -65 lines)			Patch
M	runtime/vm/ast.h	View	1	2 chunks	+3 lines, -10 lines	0 comments	Download
M	runtime/vm/ast.cc	View	1	3 chunks	+6 lines, -13 lines	0 comments	Download
M	runtime/vm/ast_transformer.cc	View	1	1 chunk	+3 lines, -3 lines	0 comments	Download
M	runtime/vm/parser.cc	View	1	14 chunks	+15 lines, -39 lines	0 comments	Download

Total messages: 4 (1 generated)

hausner

5 years, 8 months ago (2015-04-13 21:23:18 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as r45122 (presubmit successful).