Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Issue 1055543003: Rename ConstantValueComputer_InitializerCloner. (Closed)

Created:
5 years, 8 months ago by Paul Berry
Modified:
5 years, 8 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Rename ConstantValueComputer_InitializerCloner. In order to migrate constant evaluation to the new task model, this class will need to be used from outside of ConstantValueComputer, and it will need to be used on AST's for all constant values; not just those for initializers. So the old name really doesn't make any sense. R=brianwilkerson@google.com Committed: https://code.google.com/p/dart/source/detail?r=44837

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -47 lines) Patch
M pkg/analyzer/lib/src/generated/constant.dart View 3 chunks +46 lines, -47 lines 2 comments Download

Messages

Total messages: 5 (1 generated)
Paul Berry
5 years, 8 months ago (2015-04-01 16:36:02 UTC) #2
Brian Wilkerson
LGTM https://codereview.chromium.org/1055543003/diff/1/pkg/analyzer/lib/src/generated/constant.dart File pkg/analyzer/lib/src/generated/constant.dart (right): https://codereview.chromium.org/1055543003/diff/1/pkg/analyzer/lib/src/generated/constant.dart#newcode151 pkg/analyzer/lib/src/generated/constant.dart:151: // TODO(brianwilkerson) Investigate replacing uses of this class ...
5 years, 8 months ago (2015-04-01 16:39:21 UTC) #3
Paul Berry
https://codereview.chromium.org/1055543003/diff/1/pkg/analyzer/lib/src/generated/constant.dart File pkg/analyzer/lib/src/generated/constant.dart (right): https://codereview.chromium.org/1055543003/diff/1/pkg/analyzer/lib/src/generated/constant.dart#newcode151 pkg/analyzer/lib/src/generated/constant.dart:151: // TODO(brianwilkerson) Investigate replacing uses of this class with ...
5 years, 8 months ago (2015-04-01 18:12:07 UTC) #4
Paul Berry
5 years, 8 months ago (2015-04-01 18:13:13 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 44837 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698