Issue 1055243006: tree-ir: Do not merge captured parameters with other variables.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1055243006: tree-ir: Do not merge captured parameters with other variables. (Closed)

Created:
5 years, 8 months ago by asgerf

Modified:
5 years, 8 months ago

Reviewers:
Kevin Millikin (Google)

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Target Ref:
refs/remotes/git-svn

Visibility:
Public.

More Reviews

Description

tree-ir: Do not merge captured parameters with other variables. BUG= R=kmillikin@google.com Committed: https://code.google.com/p/dart/source/detail?r=45160

Patch Set 1 #

Total comments: 2

Created: 5 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -1 line)			Patch
	M	pkg/compiler/lib/src/tree_ir/optimization/variable_merger.dart	View		1 chunk	+1 line, -0 lines	1 comment	Download
	M	pkg/compiler/lib/src/tree_ir/tree_ir_builder.dart	View		1 chunk	+2 lines, -1 line	1 comment	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

asgerf

https://codereview.chromium.org/1055243006/diff/1/pkg/compiler/lib/src/tree_ir/optimization/variable_merger.dart File pkg/compiler/lib/src/tree_ir/optimization/variable_merger.dart (right): https://codereview.chromium.org/1055243006/diff/1/pkg/compiler/lib/src/tree_ir/optimization/variable_merger.dart#newcode424 pkg/compiler/lib/src/tree_ir/optimization/variable_merger.dart:424: if (parameter.isCaptured) continue; This is a bug that snuck ...

5 years, 8 months ago (2015-04-15 10:43:39 UTC) #2

asgerf

5 years, 8 months ago (2015-04-15 11:19:52 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as 45160 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages