Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issue 1055183004: Add await/async when a method with 'await' in its body is extracted. (Closed)

Created:
5 years, 8 months ago by scheglov
Modified:
5 years, 8 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Add await/async when a method with 'await' in its body is extracted. R=brianwilkerson@google.com, paulberry@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=45036

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+218 lines, -11 lines) Patch
M pkg/analysis_server/lib/src/services/refactoring/extract_method.dart View 13 chunks +68 lines, -11 lines 0 comments Download
M pkg/analysis_server/test/services/refactoring/extract_method_test.dart View 2 chunks +150 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
scheglov
5 years, 8 months ago (2015-04-09 20:49:11 UTC) #1
Paul Berry
lgtm
5 years, 8 months ago (2015-04-09 20:59:02 UTC) #2
Brian Wilkerson
LGTM
5 years, 8 months ago (2015-04-09 21:14:04 UTC) #3
scheglov
5 years, 8 months ago (2015-04-09 21:16:23 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 45036 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698