Issue 1055083004: Normalize handling of the package root in the runner.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1055083004: Normalize handling of the package root in the runner. (Closed)

Created:
5 years, 8 months ago by nweiz

Modified:
5 years, 8 months ago

Reviewers:
kevmoo

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/test@master

Target Ref:
refs/heads/master

Visibility:
Public.

Normalize handling of the package root in the runner. This standardizes all uses of the package root to look in the working directory, rather than having some uses look relative to the file being loaded. R=kevmoo@google.com Committed: https://github.com/dart-lang/test/commit/0d2ce563ce93896549eb8ee8deb941e9686fc394

Created: 5 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+82 lines, -40 lines)			Patch
M	lib/src/executable.dart	View		2 chunks	+7 lines, -0 lines	0 comments	Download
A	lib/src/runner/application_exception.dart	View		1 chunk	+14 lines, -0 lines	0 comments	Download
M	lib/src/runner/browser/server.dart	View	1	5 chunks	+9 lines, -10 lines	0 comments	Download
M	lib/src/runner/loader.dart	View		4 chunks	+6 lines, -7 lines	0 comments	Download
M	lib/src/util/io.dart	View	1 2 3	2 chunks	+9 lines, -9 lines	0 comments	Download
M	test/runner/browser/loader_test.dart	View	1 2	1 chunk	+0 lines, -9 lines	0 comments	Download
M	test/runner/loader_test.dart	View	1 2	1 chunk	+2 lines, -5 lines	0 comments	Download
M	test/utils.dart	View		2 chunks	+35 lines, -0 lines	0 comments	Download

Total messages: 3 (0 generated)

nweiz

5 years, 8 months ago (2015-04-14 21:25:19 UTC) #3

Message was sent while issue was closed.

Committed patchset #4 (id:60001) manually as
0d2ce563ce93896549eb8ee8deb941e9686fc394 (presubmit successful).