Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issue 105493003: workaround for event handlers: don't return StreamSubscription as model (Closed)

Created:
7 years ago by Jennifer Messerly
Modified:
7 years ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

workaround for event handlers: don't return StreamSubscription as model https://code.google.com/p/dart/issues/detail?id=15574 R=sigmund@google.com Committed: https://code.google.com/p/dart/source/detail?r=31092

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -8 lines) Patch
M pkg/observe/lib/src/path_observer.dart View 1 chunk +5 lines, -2 lines 0 comments Download
A pkg/polymer/CHANGELOG.md View 1 chunk +14 lines, -0 lines 0 comments Download
M pkg/polymer/README.md View 2 chunks +2 lines, -1 line 0 comments Download
M pkg/polymer/lib/src/instance.dart View 2 chunks +7 lines, -4 lines 0 comments Download
M pkg/polymer/pubspec.yaml View 1 chunk +1 line, -1 line 0 comments Download
M pkg/polymer/test/custom_event_test.dart View 2 chunks +8 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Jennifer Messerly
7 years ago (2013-12-11 23:46:32 UTC) #1
Siggi Cherem (dart-lang)
lgtm
7 years ago (2013-12-11 23:51:14 UTC) #2
Jennifer Messerly
7 years ago (2013-12-11 23:52:15 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r31092 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698