Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(730)

Issue 1054893003: Better error messages when matching parens and braces (Closed)

Created:
5 years, 8 months ago by hausner
Modified:
5 years, 8 months ago
Reviewers:
srdjan
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Better error messages when matching parens and braces Tell user where the mismatched closing paren or brace opens. Fix for 22820 and improvement for (previously closed) 2936 R=srdjan@google.com Committed: https://code.google.com/p/dart/source/detail?r=44882

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -30 lines) Patch
M runtime/vm/parser.h View 1 chunk +2 lines, -1 line 0 comments Download
M runtime/vm/parser.cc View 4 chunks +48 lines, -29 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
hausner
5 years, 8 months ago (2015-04-02 20:53:27 UTC) #2
srdjan
lgtm
5 years, 8 months ago (2015-04-03 01:14:42 UTC) #3
hausner
5 years, 8 months ago (2015-04-03 17:07:31 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as r44882 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698