Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(368)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1054863002: CssClassSet upgrade (Closed)

Created:
5 years, 8 months ago by sra1
Modified:
5 years, 8 months ago
Reviewers:
Alan Knight
CC:
reviews_dartlang.org, Jacob
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

CssClassSet upgrade - Fork implementation for Dartium and dart2js. Dartium is working fine. - dart2js version uses Element.classList (DomTokenList) for 4x speedup. - Fix bug where document.querySelectorAll(...).classes.add('x') fails for SVG elements. - Add test for above. For later: - Identify a polyfill for IE SVGElements (they don't have classList) - Simplify CssClassSet further to exploit uniform availability of classList. This should give another performance boost by enabling inlining. R=alanknight@google.com Committed: https://code.google.com/p/dart/source/detail?r=44888 Committed: https://code.google.com/p/dart/source/detail?r=44897 Committed: https://code.google.com/p/dart/source/detail?r=44898

Patch Set 1 : #

Total comments: 2

Patch Set 2 : #

Patch Set 3 : revert ahead of fixing polyfill test issues #

Patch Set 4 : baseline for fixes #

Patch Set 5 : Fix webcomponents test, IE toggle. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+742 lines, -258 lines) Patch
M sdk/lib/html/dart2js/html_dart2js.dart View 5 chunks +260 lines, -88 lines 0 comments Download
M sdk/lib/html/dartium/html_dartium.dart View 3 chunks +11 lines, -1 line 0 comments Download
M tests/html/custom/attribute_changed_callback_test.dart View 1 2 3 4 2 chunks +6 lines, -2 lines 0 comments Download
A tests/html/element_classes_svg_test.dart View 1 3 1 chunk +200 lines, -0 lines 0 comments Download
M tests/html/html.status View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M tools/dom/src/CssClassSet.dart View 3 3 chunks +7 lines, -85 lines 0 comments Download
A tools/dom/src/dart2js_CssClassSet.dart View 1 2 3 4 1 chunk +249 lines, -0 lines 0 comments Download
A + tools/dom/src/dartium_CssClassSet.dart View 3 1 chunk +1 line, -78 lines 0 comments Download
M tools/dom/templates/html/dart2js/html_dart2js.darttemplate View 3 2 chunks +6 lines, -3 lines 0 comments Download
M tools/dom/templates/html/dartium/html_dartium.darttemplate View 3 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
sra1
5 years, 8 months ago (2015-04-03 19:55:17 UTC) #7
Alan Knight
lgtm https://codereview.chromium.org/1054863002/diff/100001/tests/html/element_classes_svg_test.dart File tests/html/element_classes_svg_test.dart (right): https://codereview.chromium.org/1054863002/diff/100001/tests/html/element_classes_svg_test.dart#newcode1 tests/html/element_classes_svg_test.dart:1: // Copyright (c) 2011, the Dart project authors. ...
5 years, 8 months ago (2015-04-03 20:32:17 UTC) #8
sra1
https://codereview.chromium.org/1054863002/diff/100001/tests/html/element_classes_svg_test.dart File tests/html/element_classes_svg_test.dart (right): https://codereview.chromium.org/1054863002/diff/100001/tests/html/element_classes_svg_test.dart#newcode1 tests/html/element_classes_svg_test.dart:1: // Copyright (c) 2011, the Dart project authors. Please ...
5 years, 8 months ago (2015-04-03 20:47:42 UTC) #9
sra1
Committed patchset #2 (id:120001) manually as 44888 (presubmit successful).
5 years, 8 months ago (2015-04-03 20:48:21 UTC) #10
sra1
Committed patchset #3 (id:140001) manually as 44897 (presubmit successful).
5 years, 8 months ago (2015-04-03 22:39:06 UTC) #11
sra1
5 years, 8 months ago (2015-04-03 23:00:41 UTC) #12
Message was sent while issue was closed. 
Committed patchset #5 (id:180001) manually as 44898 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698