Issue 105453004: Remove use of deprecated mirror API from code that only runs against dart2js.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 105453004: Remove use of deprecated mirror API from code that only runs against dart2js. (Closed)

Created:
7 years ago by rmacnak

Modified:
7 years ago

Reviewers:
ahe, Jennifer Messerly

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Remove use of deprecated mirror API from code that only runs against dart2js. R=ahe@google.com, jmesserly@google.com Committed: https://code.google.com/p/dart/source/detail?r=30902

Patch Set 1 #

Created: 7 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -5 lines)			Patch
	M	pkg/polymer/lib/src/reflected_type.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	tests/compiler/dart2js_extra/mirror_printer_test.dart	View		3 chunks	+8 lines, -4 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Jennifer Messerly

Just checking: this change is backwards compatible with the Dart 1.0 SDK, right? Otherwise we ...

7 years ago (2013-12-05 22:39:32 UTC) #5

rmacnak

7 years ago (2013-12-05 23:13:14 UTC) #6

Message was sent while issue was closed.

On 2013/12/05 22:39:32, John Messerly wrote:
> Just checking: this change is backwards compatible with the Dart 1.0 SDK,
right?

Yes, Class/LibraryMirror.declarations was added in late October.

> Otherwise we should bump the SDK version constraint in Polymer/pubspec.yaml
> before we publish it.

Expand Messages | Collapse Messages