Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(328)

Issue 1053723002: Fix a null-pointer reference and minor clean-up (Closed)

Created:
5 years, 8 months ago by Brian Wilkerson
Modified:
5 years, 8 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix a null-pointer reference and minor clean-up R=scheglov@google.com Committed: https://code.google.com/p/dart/source/detail?r=44844

Patch Set 1 #

Total comments: 2

Patch Set 2 : Added tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -3 lines) Patch
M pkg/analysis_server/lib/src/services/correction/fix_internal.dart View 2 chunks +5 lines, -3 lines 0 comments Download
M pkg/analysis_server/test/services/correction/fix_test.dart View 1 1 chunk +16 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Brian Wilkerson
5 years, 8 months ago (2015-04-01 15:47:44 UTC) #2
scheglov
https://codereview.chromium.org/1053723002/diff/1/pkg/analysis_server/lib/src/services/correction/fix_internal.dart File pkg/analysis_server/lib/src/services/correction/fix_internal.dart (right): https://codereview.chromium.org/1053723002/diff/1/pkg/analysis_server/lib/src/services/correction/fix_internal.dart#newcode381 pkg/analysis_server/lib/src/services/correction/fix_internal.dart:381: } Could you add a test for this? Probably ...
5 years, 8 months ago (2015-04-01 17:11:30 UTC) #3
Brian Wilkerson
https://codereview.chromium.org/1053723002/diff/1/pkg/analysis_server/lib/src/services/correction/fix_internal.dart File pkg/analysis_server/lib/src/services/correction/fix_internal.dart (right): https://codereview.chromium.org/1053723002/diff/1/pkg/analysis_server/lib/src/services/correction/fix_internal.dart#newcode381 pkg/analysis_server/lib/src/services/correction/fix_internal.dart:381: } Done
5 years, 8 months ago (2015-04-01 20:56:37 UTC) #4
scheglov
LGTM
5 years, 8 months ago (2015-04-01 20:57:17 UTC) #5
Brian Wilkerson
5 years, 8 months ago (2015-04-01 20:57:45 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 44844 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698