Do not register service isolate descendants with service

Do not register service isolate descendants with service

Committed: https://code.google.com/p/dart/source/detail?r=44842

[Cutch, 2015-04-01 15:33:11]

johnmccutchan@google.com changed reviewers:
+ turnidge@google.com

[turnidge, 2015-04-01 19:57:34]

LGTMwC

https://codereview.chromium.org/1053713003/diff/1/runtime/vm/service.cc
File runtime/vm/service.cc (right):

https://codereview.chromium.org/1053713003/diff/1/runtime/vm/service.cc#newco...
runtime/vm/service.cc:533: if
(ServiceIsolate::IsServiceIsolateDescendant(Isolate::Current())) {
Make this an assert.  Collapse to single test.

https://codereview.chromium.org/1053713003/diff/1/runtime/vm/service.cc#newco...
runtime/vm/service.cc:599:
ServiceIsolate::IsServiceIsolateDescendant(Isolate::Current())) {
Collapse to one test.

https://codereview.chromium.org/1053713003/diff/1/runtime/vm/service.cc#newco...
runtime/vm/service.cc:2427:
!ServiceIsolate::IsServiceIsolateDescendant(isolate)) {
Collapse test.

https://codereview.chromium.org/1053713003/diff/1/runtime/vm/service_isolate.cc
File runtime/vm/service_isolate.cc (right):

https://codereview.chromium.org/1053713003/diff/1/runtime/vm/service_isolate....
runtime/vm/service_isolate.cc:186: (isolate->origin_id() ==
ServiceIsolate::Origin())) {
Can this whole test get replaces by ServiceIsolate:IsServiceIsolateBlah?

https://codereview.chromium.org/1053713003/diff/1/runtime/vm/service_isolate....
runtime/vm/service_isolate.cc:422: if (IsServiceIsolate(isolate) ||
IsServiceIsolateDescendant(isolate)) {
Collapse and ditto below.

https://codereview.chromium.org/1053713003/diff/1/runtime/vm/service_isolate....
runtime/vm/service_isolate.cc:533: SetServiceIsolate(isolate);
Consider having this call set the origin as well, as discussed.

https://codereview.chromium.org/1053713003/diff/1/runtime/vm/service_isolate.h
File runtime/vm/service_isolate.h (right):

https://codereview.chromium.org/1053713003/diff/1/runtime/vm/service_isolate....
runtime/vm/service_isolate.h:25: static Dart_Port Origin();
Does this need to be provided?

[Cutch, 2015-04-01 20:19:05]

https://codereview.chromium.org/1053713003/diff/1/runtime/vm/service.cc
File runtime/vm/service.cc (right):

https://codereview.chromium.org/1053713003/diff/1/runtime/vm/service.cc#newco...
runtime/vm/service.cc:533: if
(ServiceIsolate::IsServiceIsolateDescendant(Isolate::Current())) {
On 2015/04/01 19:57:34, turnidge wrote:
> Make this an assert.  Collapse to single test.

Done.

https://codereview.chromium.org/1053713003/diff/1/runtime/vm/service.cc#newco...
runtime/vm/service.cc:599:
ServiceIsolate::IsServiceIsolateDescendant(Isolate::Current())) {
On 2015/04/01 19:57:34, turnidge wrote:
> Collapse to one test.

Done.

https://codereview.chromium.org/1053713003/diff/1/runtime/vm/service.cc#newco...
runtime/vm/service.cc:2427:
!ServiceIsolate::IsServiceIsolateDescendant(isolate)) {
On 2015/04/01 19:57:34, turnidge wrote:
> Collapse test.

Done.

https://codereview.chromium.org/1053713003/diff/1/runtime/vm/service_isolate.cc
File runtime/vm/service_isolate.cc (right):

https://codereview.chromium.org/1053713003/diff/1/runtime/vm/service_isolate....
runtime/vm/service_isolate.cc:186: (isolate->origin_id() ==
ServiceIsolate::Origin())) {
On 2015/04/01 19:57:34, turnidge wrote:
> Can this whole test get replaces by ServiceIsolate:IsServiceIsolateBlah?

Done.

https://codereview.chromium.org/1053713003/diff/1/runtime/vm/service_isolate....
runtime/vm/service_isolate.cc:422: if (IsServiceIsolate(isolate) ||
IsServiceIsolateDescendant(isolate)) {
On 2015/04/01 19:57:34, turnidge wrote:
> Collapse and ditto below.

Done.

https://codereview.chromium.org/1053713003/diff/1/runtime/vm/service_isolate....
runtime/vm/service_isolate.cc:533: SetServiceIsolate(isolate);
On 2015/04/01 19:57:34, turnidge wrote:
> Consider having this call set the origin as well, as discussed.

Done.

https://codereview.chromium.org/1053713003/diff/1/runtime/vm/service_isolate.h
File runtime/vm/service_isolate.h (right):

https://codereview.chromium.org/1053713003/diff/1/runtime/vm/service_isolate....
runtime/vm/service_isolate.h:25: static Dart_Port Origin();
On 2015/04/01 19:57:34, turnidge wrote:
> Does this need to be provided?

Done.

[Cutch, 2015-04-01 20:23:49]

Committed patchset #2 (id:20001) manually as 44842 (presubmit successful).