Initial re-write of analysis context for the new task model

Initial re-write of analysis context for the new task model

R=scheglov@google.com

Committed: https://code.google.com/p/dart/source/detail?r=45284

[Brian Wilkerson, 2015-04-20 00:04:01]

brianwilkerson@google.com changed reviewers:
+ scheglov@google.com

[Brian Wilkerson, 2015-04-20 00:04:02]

Many of the tests currently fail, but I want other people to be able to work on
it.

[scheglov, 2015-04-20 03:44:50]

LGTM

https://codereview.chromium.org/1053673008/diff/1/pkg/analyzer/lib/src/contex...
File pkg/analyzer/lib/src/context/context.dart (right):

https://codereview.chromium.org/1053673008/diff/1/pkg/analyzer/lib/src/contex...
pkg/analyzer/lib/src/context/context.dart:895: // TODO(brianwilkerson) The
public namespace used to be cached, but no is.
The only client of this method is NamespaceBuilder._createExportMapping(), and
it is not used with tasks - instead we compute export namespace once using
BuildExportNamespaceTask and reuse in scopes.

https://codereview.chromium.org/1053673008/diff/1/pkg/analyzer/lib/src/genera...
File pkg/analyzer/lib/src/generated/engine.dart (right):

https://codereview.chromium.org/1053673008/diff/1/pkg/analyzer/lib/src/genera...
pkg/analyzer/lib/src/generated/engine.dart:5786: bool enableUnionTypes = false;
IIRC Paul removed union types support some a week or two ago.

[Brian Wilkerson, 2015-04-20 15:00:21]

Committed patchset #1 (id:1) manually as 45284 (presubmit successful).

[Brian Wilkerson, 2015-04-20 15:00:36]

https://codereview.chromium.org/1053673008/diff/1/pkg/analyzer/lib/src/contex...
File pkg/analyzer/lib/src/context/context.dart (right):

https://codereview.chromium.org/1053673008/diff/1/pkg/analyzer/lib/src/contex...
pkg/analyzer/lib/src/context/context.dart:895: // TODO(brianwilkerson) The
public namespace used to be cached, but no is.
> The only client of this method is NamespaceBuilder._createExportMapping(), and
> it is not used with tasks - instead we compute export namespace once using
> BuildExportNamespaceTask and reuse in scopes.

Clean-up (by someone) in a later CL.

https://codereview.chromium.org/1053673008/diff/1/pkg/analyzer/lib/src/genera...
File pkg/analyzer/lib/src/generated/engine.dart (right):

https://codereview.chromium.org/1053673008/diff/1/pkg/analyzer/lib/src/genera...
pkg/analyzer/lib/src/generated/engine.dart:5786: bool enableUnionTypes = false;
On 2015/04/20 03:44:50, scheglov wrote:
> IIRC Paul removed union types support some a week or two ago.

Yes. That resulted from a merge issue. I've re-removed them. Thanks!

[kevmoo, 2015-04-20 16:27:27]

kevmoo@google.com changed reviewers:
+ kevmoo@google.com

[kevmoo, 2015-04-20 16:27:28]

DBC: this looked a bit weird...

https://codereview.chromium.org/1053673008/diff/1/pkg/analyzer/lib/src/genera...
File pkg/analyzer/lib/src/generated/engine.dart (right):

https://codereview.chromium.org/1053673008/diff/1/pkg/analyzer/lib/src/genera...
pkg/analyzer/lib/src/generated/engine.dart:16: import
'package:analyzer/src/context/context.dart' as cache;
Two imports both 'as cache'

[Brian Wilkerson, 2015-04-20 16:29:52]

https://codereview.chromium.org/1053673008/diff/1/pkg/analyzer/lib/src/genera...
File pkg/analyzer/lib/src/generated/engine.dart (right):

https://codereview.chromium.org/1053673008/diff/1/pkg/analyzer/lib/src/genera...
pkg/analyzer/lib/src/generated/engine.dart:16: import
'package:analyzer/src/context/context.dart' as cache;
You're right. That was a copy/paste error. I'll clean it up later. Thanks!