Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Issue 1053673004: Handle local get through semantic visitor methods. (Closed)

Created:
5 years, 8 months ago by Johnni Winther
Modified:
5 years, 8 months ago
Reviewers:
karlklose
CC:
reviews_dartlang.org, Harry Terkelsen, Siggi Cherem (dart-lang)
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Handle local get through semantic visitor methods. BUG= R=karlklose@google.com Committed: https://code.google.com/p/dart/source/detail?r=45066

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -9 lines) Patch
M pkg/compiler/lib/src/inferrer/concrete_types_inferrer.dart View 1 chunk +12 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/inferrer/simple_types_inferrer.dart View 1 chunk +23 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/ssa/builder.dart View 1 chunk +26 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Johnni Winther
het@, sigmund@: This is an example of the refactoring I've talking about; moving code from ...
5 years, 8 months ago (2015-04-10 08:49:24 UTC) #2
karlklose
LGTM.
5 years, 8 months ago (2015-04-10 11:56:33 UTC) #3
Johnni Winther
5 years, 8 months ago (2015-04-10 14:17:48 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 45066 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698