Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(289)

Issue 1053663002: add type completions after "on" in a try block (Closed)

Created:
5 years, 8 months ago by danrubel
Modified:
5 years, 8 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

add type completions after "on" in a try block BUG=dartbug.com/23028 R=scheglov@google.com Committed: https://code.google.com/p/dart/source/detail?r=44839

Patch Set 1 #

Patch Set 2 : merge #

Patch Set 3 : fix tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -3 lines) Patch
M pkg/analysis_server/lib/src/services/completion/optype.dart View 1 chunk +7 lines, -0 lines 0 comments Download
M pkg/analysis_server/test/completion_test.dart View 1 2 2 chunks +2 lines, -3 lines 0 comments Download
M pkg/analysis_server/test/services/completion/completion_test_util.dart View 1 chunk +27 lines, -0 lines 0 comments Download
M pkg/analysis_server/test/services/completion/optype_test.dart View 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
danrubel
5 years, 8 months ago (2015-04-01 13:05:09 UTC) #2
scheglov
LGTM
5 years, 8 months ago (2015-04-01 14:45:41 UTC) #3
danrubel
5 years, 8 months ago (2015-04-01 19:30:03 UTC) #4
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as 44839 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698