Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1053443002: Rename the package to "test". (Closed)

Created:
5 years, 8 months ago by nweiz
Modified:
5 years, 8 months ago
Reviewers:
kevmoo
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/test@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Fix executable. #

Patch Set 3 : Changelog entry. #

Patch Set 4 : Version number. #

Patch Set 5 : Fix a test. #

Total comments: 1

Patch Set 6 : Code review changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1744 lines, -1952 lines) Patch
M CHANGELOG.md View 1 2 4 chunks +10 lines, -4 lines 0 comments Download
M README.md View 10 chunks +22 lines, -22 lines 0 comments Download
A + bin/test.dart View 1 4 chunks +10 lines, -10 lines 0 comments Download
M bin/unittest.dart View 1 1 chunk +0 lines, -171 lines 0 comments Download
M codereview.settings View 1 chunk +1 line, -1 line 0 comments Download
M lib/compact_vm_config.dart View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M lib/html_config.dart View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M lib/html_enhanced_config.dart View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M lib/html_individual_config.dart View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M lib/src/backend/declarer.dart View 1 chunk +1 line, -1 line 0 comments Download
M lib/src/backend/group.dart View 1 chunk +1 line, -1 line 0 comments Download
M lib/src/backend/invoker.dart View 3 chunks +3 lines, -3 lines 0 comments Download
M lib/src/backend/live_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M lib/src/backend/live_test_controller.dart View 1 chunk +1 line, -1 line 0 comments Download
M lib/src/backend/metadata.dart View 1 chunk +1 line, -1 line 0 comments Download
M lib/src/backend/operating_system.dart View 1 chunk +1 line, -1 line 0 comments Download
M lib/src/backend/platform_selector.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M lib/src/backend/platform_selector/ast.dart View 1 chunk +1 line, -1 line 0 comments Download
M lib/src/backend/platform_selector/evaluator.dart View 1 chunk +1 line, -1 line 0 comments Download
M lib/src/backend/platform_selector/parser.dart View 1 chunk +1 line, -1 line 0 comments Download
M lib/src/backend/platform_selector/scanner.dart View 1 chunk +1 line, -1 line 0 comments Download
M lib/src/backend/platform_selector/token.dart View 1 chunk +1 line, -1 line 0 comments Download
M lib/src/backend/platform_selector/visitor.dart View 1 chunk +1 line, -1 line 0 comments Download
M lib/src/backend/state.dart View 1 chunk +1 line, -1 line 0 comments Download
M lib/src/backend/suite.dart View 1 chunk +1 line, -1 line 0 comments Download
M lib/src/backend/test.dart View 1 chunk +1 line, -1 line 0 comments Download
M lib/src/backend/test_platform.dart View 1 chunk +1 line, -1 line 0 comments Download
M lib/src/deprecated/configuration.dart View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M lib/src/deprecated/simple_configuration.dart View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M lib/src/deprecated/test_case.dart View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M lib/src/frontend/expect.dart View 1 chunk +1 line, -1 line 0 comments Download
M lib/src/frontend/expect_async.dart View 3 chunks +3 lines, -3 lines 0 comments Download
M lib/src/frontend/future_matchers.dart View 1 chunk +1 line, -1 line 0 comments Download
M lib/src/frontend/prints_matcher.dart View 1 chunk +1 line, -1 line 0 comments Download
M lib/src/frontend/test_on.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M lib/src/frontend/throws_matcher.dart View 1 chunk +1 line, -1 line 0 comments Download
M lib/src/frontend/throws_matchers.dart View 1 chunk +1 line, -1 line 0 comments Download
M lib/src/runner/browser/browser_manager.dart View 1 chunk +1 line, -1 line 0 comments Download
M lib/src/runner/browser/chrome.dart View 1 chunk +1 line, -1 line 0 comments Download
M lib/src/runner/browser/compiler_pool.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M lib/src/runner/browser/iframe_listener.dart View 3 chunks +3 lines, -3 lines 0 comments Download
M lib/src/runner/browser/iframe_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M lib/src/runner/browser/server.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M lib/src/runner/browser/static/host.dart View 2 chunks +4 lines, -4 lines 0 comments Download
M lib/src/runner/browser/static/host.dart.js View 1 2 3 4 197 chunks +1492 lines, -1344 lines 0 comments Download
M lib/src/runner/browser/static/host.dart.js.map View 1 2 3 4 1 chunk +3 lines, -3 lines 0 comments Download
M lib/src/runner/browser/static/index.html View 1 chunk +1 line, -1 line 0 comments Download
M lib/src/runner/engine.dart View 1 chunk +1 line, -1 line 0 comments Download
M lib/src/runner/load_exception.dart View 1 chunk +1 line, -1 line 0 comments Download
M lib/src/runner/loader.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M lib/src/runner/parse_metadata.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M lib/src/runner/reporter/compact.dart View 1 chunk +1 line, -1 line 0 comments Download
M lib/src/runner/reporter/no_io_compact.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M lib/src/runner/vm/isolate_listener.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M lib/src/runner/vm/isolate_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M lib/src/util/dart.dart View 1 chunk +1 line, -1 line 0 comments Download
M lib/src/util/exit_codes.dart View 1 chunk +1 line, -1 line 0 comments Download
M lib/src/util/io.dart View 3 chunks +4 lines, -4 lines 0 comments Download
M lib/src/util/isolate_wrapper.dart View 1 chunk +1 line, -1 line 0 comments Download
M lib/src/util/multi_channel.dart View 1 chunk +1 line, -1 line 0 comments Download
M lib/src/util/one_off_handler.dart View 1 chunk +1 line, -1 line 0 comments Download
M lib/src/util/remote_exception.dart View 1 chunk +1 line, -1 line 0 comments Download
M lib/src/util/stream_channel.dart View 1 chunk +1 line, -1 line 0 comments Download
M lib/src/utils.dart View 2 chunks +3 lines, -3 lines 0 comments Download
A + lib/test.dart View 1 2 3 4 5 5 chunks +5 lines, -5 lines 0 comments Download
M lib/unittest.dart View 1 2 3 4 5 1 chunk +0 lines, -191 lines 0 comments Download
M lib/vm_config.dart View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M pubspec.yaml View 3 2 chunks +3 lines, -3 lines 0 comments Download
M test/backend/declarer_test.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M test/backend/invoker_test.dart View 1 chunk +5 lines, -5 lines 0 comments Download
M test/backend/platform_selector/ast_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M test/backend/platform_selector/evaluate_test.dart View 1 chunk +4 lines, -4 lines 0 comments Download
M test/backend/platform_selector/parser_test.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M test/backend/platform_selector/scanner_test.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M test/frontend/expect_async_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M test/frontend/matcher/completion_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M test/frontend/matcher/prints_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M test/frontend/matcher/throws_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M test/frontend/matcher/throws_type_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M test/io.dart View 1 chunk +6 lines, -6 lines 0 comments Download
M test/runner/browser/chrome_test.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M test/runner/browser/compact_reporter_test.dart View 3 chunks +3 lines, -3 lines 0 comments Download
M test/runner/browser/compiler_pool_test.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M test/runner/browser/loader_test.dart View 3 chunks +7 lines, -7 lines 0 comments Download
M test/runner/browser/runner_test.dart View 7 chunks +8 lines, -8 lines 0 comments Download
M test/runner/compact_reporter_test.dart View 1 2 3 4 3 chunks +4 lines, -4 lines 0 comments Download
M test/runner/engine_test.dart View 1 chunk +5 lines, -5 lines 0 comments Download
M test/runner/isolate_listener_test.dart View 1 chunk +10 lines, -10 lines 0 comments Download
M test/runner/loader_test.dart View 5 chunks +8 lines, -8 lines 0 comments Download
M test/runner/parse_metadata_test.dart View 2 chunks +6 lines, -6 lines 0 comments Download
M test/runner/runner_test.dart View 9 chunks +10 lines, -10 lines 0 comments Download
M test/runner/test_on_test.dart View 3 chunks +4 lines, -4 lines 0 comments Download
M test/util/multi_channel_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M test/util/one_off_handler_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M test/util/string_literal_iterator_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M test/utils.dart View 1 chunk +9 lines, -9 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
nweiz
5 years, 8 months ago (2015-04-01 00:10:52 UTC) #1
nweiz
Oops, this was supposed to go to Kevin.
5 years, 8 months ago (2015-04-01 00:52:10 UTC) #3
kevmoo
lgtm https://codereview.chromium.org/1053443002/diff/80001/lib/compact_vm_config.dart File lib/compact_vm_config.dart (right): https://codereview.chromium.org/1053443002/diff/80001/lib/compact_vm_config.dart#newcode13 lib/compact_vm_config.dart:13: /// This is a stub class used to ...
5 years, 8 months ago (2015-04-01 00:55:15 UTC) #4
nweiz
Code review changes
5 years, 8 months ago (2015-04-01 01:05:53 UTC) #5
nweiz
5 years, 8 months ago (2015-04-01 01:06:00 UTC) #6
Message was sent while issue was closed. 
Committed patchset #6 (id:100001) manually as
0d5c09b502e03dacc2b92c74f579214843dd06a5 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698