Issue 1053323002: Issue 22988. Improve checking for conflicts between parameters and local elements during extracting…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1053323002: Issue 22988. Improve checking for conflicts between parameters and local elements during extracting… (Closed)

Created:
5 years, 8 months ago by scheglov

Modified:
5 years, 8 months ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Target Ref:
refs/remotes/git-svn

Visibility:
Public.

More Reviews

Description

Issue 22988. Improve checking for conflicts between parameters and local elements during extracting methods. R=brianwilkerson@google.com BUG= https://code.google.com/p/dart/issues/detail?id=22988 Committed: https://code.google.com/p/dart/source/detail?r=44891

Patch Set 2 : Clean up. #

Created: 5 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+147 lines, -43 lines)			Patch
M	pkg/analysis_server/lib/src/services/refactoring/extract_method.dart	View	1	4 chunks	+76 lines, -39 lines	0 comments	Download
M	pkg/analysis_server/test/mock_sdk.dart	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	pkg/analysis_server/test/services/refactoring/extract_method_test.dart	View	1	3 chunks	+69 lines, -1 line	0 comments	Download
M	pkg/analyzer/lib/src/generated/resolver.dart	View		1 chunk	+1 line, -3 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Brian Wilkerson

LGTM https://codereview.chromium.org/1053323002/diff/1/pkg/analysis_server/lib/src/services/refactoring/extract_method.dart File pkg/analysis_server/lib/src/services/refactoring/extract_method.dart (right): https://codereview.chromium.org/1053323002/diff/1/pkg/analysis_server/lib/src/services/refactoring/extract_method.dart#newcode368 pkg/analysis_server/lib/src/services/refactoring/extract_method.dart:368: // TODO Remove or expand (explain what needs ...

5 years, 8 months ago (2015-04-03 21:00:41 UTC) #2

scheglov

5 years, 8 months ago (2015-04-03 21:04:35 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as 44891 (presubmit successful).

Expand Messages | Collapse Messages

Issue 1053323002: Issue 22988. Improve checking for conflicts between parameters and local elements during extracting… (Closed)

Description

Patch Set 1 #

Patch Set 2 : Clean up. #

Messages