Issue 105273005: Redo "Redo "Use TypedArray.set for setRange of between similarly typed lists implemented as TypedAr…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 105273005: Redo "Redo "Use TypedArray.set for setRange of between similarly typed lists implemented as TypedAr… (Closed)

Created:
7 years ago by sra1

Modified:
7 years ago

Reviewers:
Cutch

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Redo "Redo "Use TypedArray.set for setRange of between similarly typed lists implemented as TypedArrays"" What has changed here is I split the test to allow Safari to me marked as failing some tests. Committed: https://code.google.com/p/dart/source/detail?r=30921

Patch Set 1 #

Patch Set 2 : #

Created: 7 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+138 lines, -207 lines)			Patch
M	sdk/lib/typed_data/dart2js/typed_data_dart2js.dart	View	1	16 chunks	+74 lines, -47 lines	0 comments	Download
M	tests/lib/lib.status	View	1	3 chunks	+8 lines, -4 lines	0 comments	Download
A +	tests/lib/typed_data/setRange_1_test.dart	View	1	1 chunk	+6 lines, -5 lines	0 comments	Download
A +	tests/lib/typed_data/setRange_2_test.dart	View	1	1 chunk	+8 lines, -7 lines	0 comments	Download
A	tests/lib/typed_data/setRange_3_test.dart	View	1	1 chunk	+35 lines, -0 lines	0 comments	Download
A +	tests/lib/typed_data/setRange_lib.dart	View	1	3 chunks	+7 lines, -43 lines	0 comments	Download
D	tests/lib/typed_data/typed_data_setRange_test.dart	View	1	1 chunk	+0 lines, -101 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Message was sent while issue was closed.

lgtm

Expand Messages | Collapse Messages