Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(214)

Issue 1052653002: Fix length computation on init.mangledNames. (Closed)

Created:
5 years, 8 months ago by herhut
Modified:
5 years, 8 months ago
Reviewers:
zarah
CC:
reviews_dartlang.org, floitsch, sra1
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Fix length computation on init.mangledNames. BUG= http://dartbug.com/23054 R=zarah@google.com Committed: https://code.google.com/p/dart/source/detail?r=44831

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -1 line) Patch
M sdk/lib/_internal/compiler/js_lib/js_names.dart View 1 chunk +2 lines, -1 line 0 comments Download
A tests/lib/mirrors/reflect_two_classes_test.dart View 1 chunk +37 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
herhut
I used [length] on an object, which obviously does not work in JavaScript but does ...
5 years, 8 months ago (2015-04-01 12:24:35 UTC) #1
zarah
LGTM
5 years, 8 months ago (2015-04-01 12:27:49 UTC) #2
herhut
5 years, 8 months ago (2015-04-01 12:29:32 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 44831 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698