add console error about bad packages paths in html imports

add console error about bad packages paths in html imports

R=sigmund@google.com

Committed: https://github.com/dart-lang/web-components/commit/c39c82a0e429527488bf5053da9a0313703e24c9

[jakemac, 2015-04-01 18:10:42]

jakemac@google.com changed reviewers:
+ sigmund@google.com

[Siggi Cherem (dart-lang), 2015-04-01 21:37:05]

LGTM

https://codereview.chromium.org/1052523004/diff/1/lib/src/mirror_initializer....
File lib/src/mirror_initializer.dart (right):

https://codereview.chromium.org/1052523004/diff/1/lib/src/mirror_initializer....
lib/src/mirror_initializer.dart:171: url.relative(import.href, from:
url.dirname(entryPath));
just to double check, is import.href resolved to be an absolute url? If so,
let's add a little comment about it - if not, then I imagine here we would need
to know what is the path of the containing document so we can compute the joined
path.

https://codereview.chromium.org/1052523004/diff/1/lib/src/mirror_initializer....
lib/src/mirror_initializer.dart:179: 1);
the format here looks really strange. formatter bug? maybe add a tmp var to help

[jakemac, 2015-04-02 14:34:06]

https://codereview.chromium.org/1052523004/diff/1/lib/src/mirror_initializer....
File lib/src/mirror_initializer.dart (right):

https://codereview.chromium.org/1052523004/diff/1/lib/src/mirror_initializer....
lib/src/mirror_initializer.dart:171: url.relative(import.href, from:
url.dirname(entryPath));
On 2015/04/01 21:37:05, Siggi Cherem (dart-lang) wrote:
> just to double check, is import.href resolved to be an absolute url? If so,
> let's add a little comment about it - if not, then I imagine here we would
need
> to know what is the path of the containing document so we can compute the
joined
> path.
> 

Yes its the absolute url

https://codereview.chromium.org/1052523004/diff/1/lib/src/mirror_initializer....
lib/src/mirror_initializer.dart:179: 1);
On 2015/04/01 21:37:05, Siggi Cherem (dart-lang) wrote:
> the format here looks really strange. formatter bug? maybe add a tmp var to
help

done

[jakemac, 2015-04-02 14:34:58]

Committed patchset #3 (id:40001) manually as
c39c82a0e429527488bf5053da9a0313703e24c9 (presubmit successful).