Issue 1052353003: Fix a bug where pub would fail to load a transformer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1052353003: Fix a bug where pub would fail to load a transformer. (Closed)

Created:
5 years, 8 months ago by nweiz

Modified:
5 years, 8 months ago

Reviewers:
Bob Nystrom

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Target Ref:
refs/remotes/git-svn

Visibility:
Public.

More Reviews

Description

Fix a bug where pub would fail to load a transformer. If a transformer is defined in a dependency, used in the root package, and restricted (via $include or $exclude) to only run on files in test/, pub will think it's not necessary and fail to load it. R=rnystrom@google.com Committed: https://code.google.com/p/dart/source/detail?r=44876

Patch Set 1 #

Created: 5 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+23 lines, -1 line)			Patch
	M	sdk/lib/_internal/pub/lib/src/barback/dependency_computer.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	sdk/lib/_internal/pub/test/dependency_computer/dev_transformers_test.dart	View		1 chunk	+22 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

nweiz

5 years, 8 months ago (2015-04-02 22:44:22 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as 44876 (presubmit successful).

Expand Messages | Collapse Messages