Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(249)

Issue 1052243002: Implement the new '??=' operator in analyzer. (Closed)

Created:
5 years, 8 months ago by Paul Berry
Modified:
5 years, 8 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Implement the new '??=' operator in analyzer. As in r44802, the new operator is only accepted by the tokenizer if the command-line option "--enable-null-aware-operators" is supplied. Only static analysis of '??=' is implemented; however, the tests in tests/language will verify behavior once it is implemented. R=scheglov@google.com Committed: https://code.google.com/p/dart/source/detail?r=44873

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+482 lines, -2 lines) Patch
M pkg/analyzer/lib/src/generated/element_resolver.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/analyzer/lib/src/generated/error_verifier.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/analyzer/lib/src/generated/static_type_analyzer.dart View 1 chunk +5 lines, -0 lines 0 comments Download
M pkg/analyzer/test/generated/non_error_resolver_test.dart View 2 chunks +31 lines, -0 lines 0 comments Download
M pkg/analyzer/test/generated/resolver_test.dart View 1 chunk +18 lines, -0 lines 0 comments Download
M pkg/analyzer/test/generated/static_type_warning_code_test.dart View 1 chunk +15 lines, -0 lines 0 comments Download
A tests/language/if_null_assignment_behavior_test.dart View 1 chunk +203 lines, -0 lines 0 comments Download
A tests/language/if_null_assignment_helper.dart View 1 chunk +40 lines, -0 lines 0 comments Download
A tests/language/if_null_assignment_static_test.dart View 1 chunk +160 lines, -0 lines 0 comments Download
M tests/language/language.status View 1 chunk +2 lines, -0 lines 0 comments Download
M tests/language/language_analyzer.status View 1 chunk +2 lines, -0 lines 0 comments Download
M tests/language/language_dart2js.status View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Paul Berry
5 years, 8 months ago (2015-04-02 16:35:39 UTC) #2
scheglov
LGTM
5 years, 8 months ago (2015-04-02 17:01:42 UTC) #3
Paul Berry
5 years, 8 months ago (2015-04-02 20:37:25 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 44873 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698