Issue 105203006: Reverting 30868 and 30873.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 105203006: Reverting 30868 and 30873. (Closed)

Created:
7 years ago by Jennifer Messerly

Modified:
7 years ago

Reviewers:
blois

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Reverting 30868 and 30873. There's still a problem in document_register_type_extensions_test that isn't obvious. Need more time to investigate. Committed: https://code.google.com/p/dart/source/detail?r=30875

Patch Set 1 #

Created: 7 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+409 lines, -425 lines)			Patch
M	pkg/custom_element/lib/custom-elements.debug.js	View	18 chunks	+379 lines, -392 lines	0 comments	Download
M	pkg/custom_element/lib/custom-elements.min.js	View	1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/custom_element/pubspec.yaml	View	1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/template_binding/lib/src/instance_binding_map.dart	View	2 chunks	+14 lines, -3 lines	0 comments	Download
M	pkg/template_binding/lib/src/template.dart	View	6 chunks	+12 lines, -26 lines	0 comments	Download
M	pkg/template_binding/pubspec.yaml	View	2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Jennifer Messerly

Committed patchset #1 manually as r30875 (presubmit successful).

7 years ago (2013-12-04 22:52:00 UTC) #2

Jennifer Messerly

7 years ago (2013-12-04 23:50:28 UTC) #3

Message was sent while issue was closed.

On 2013/12/04 22:52:00, John Messerly wrote:
> Committed patchset #1 manually as r30875 (presubmit successful).

doh, apparently the revert script doesn't like being run twice & dropped the
second revert. :|

Expand Messages | Collapse Messages