Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 105133004: Add File.copy(Sync) to dart:io. (Closed)

Created:
7 years ago by Anders Johnsen
Modified:
7 years ago
Reviewers:
Søren Gjesse
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Add File.copy(Sync) to dart:io. BUG= R=sgjesse@google.com Committed: https://code.google.com/p/dart/source/detail?r=31125

Patch Set 1 #

Total comments: 3

Patch Set 2 : Fix permissions. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+347 lines, -68 lines) Patch
M runtime/bin/builtin_natives.cc View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/bin/file.h View 2 chunks +2 lines, -0 lines 0 comments Download
M runtime/bin/file.cc View 2 chunks +30 lines, -0 lines 0 comments Download
M runtime/bin/file_android.cc View 1 2 chunks +42 lines, -0 lines 0 comments Download
M runtime/bin/file_linux.cc View 1 2 chunks +42 lines, -0 lines 0 comments Download
M runtime/bin/file_macos.cc View 1 2 chunks +14 lines, -0 lines 0 comments Download
M runtime/bin/file_patch.dart View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/bin/file_win.cc View 1 chunk +21 lines, -0 lines 0 comments Download
M runtime/bin/io_service.h View 1 chunk +35 lines, -34 lines 0 comments Download
M sdk/lib/io/file.dart View 1 chunk +20 lines, -0 lines 0 comments Download
M sdk/lib/io/file_impl.dart View 1 chunk +18 lines, -0 lines 0 comments Download
M sdk/lib/io/io_service.dart View 1 chunk +35 lines, -34 lines 0 comments Download
A tests/standalone/io/file_copy_test.dart View 1 chunk +86 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Anders Johnsen
7 years ago (2013-12-13 10:50:15 UTC) #1
Søren Gjesse
LGTM! https://codereview.chromium.org/105133004/diff/1/runtime/bin/file_android.cc File runtime/bin/file_android.cc (right): https://codereview.chromium.org/105133004/diff/1/runtime/bin/file_android.cc#newcode231 runtime/bin/file_android.cc:231: open(new_path, O_WRONLY | O_TRUNC | O_CREAT | O_CLOEXEC, ...
7 years ago (2013-12-13 11:32:09 UTC) #2
Søren Gjesse
https://codereview.chromium.org/105133004/diff/1/runtime/bin/file_android.cc File runtime/bin/file_android.cc (right): https://codereview.chromium.org/105133004/diff/1/runtime/bin/file_android.cc#newcode231 runtime/bin/file_android.cc:231: open(new_path, O_WRONLY | O_TRUNC | O_CREAT | O_CLOEXEC, 0666)); ...
7 years ago (2013-12-13 11:57:38 UTC) #3
Anders Johnsen
https://codereview.chromium.org/105133004/diff/1/runtime/bin/file_android.cc File runtime/bin/file_android.cc (right): https://codereview.chromium.org/105133004/diff/1/runtime/bin/file_android.cc#newcode231 runtime/bin/file_android.cc:231: open(new_path, O_WRONLY | O_TRUNC | O_CREAT | O_CLOEXEC, 0666)); ...
7 years ago (2013-12-13 12:04:16 UTC) #4
Anders Johnsen
7 years ago (2013-12-13 12:04:37 UTC) #5
Message was sent while issue was closed. 
Committed patchset #2 manually as r31125 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698