Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(268)

Issue 1051223003: dartj2s: add constructor helpers for map literals with no type parameters. (Closed)

Created:
5 years, 8 months ago by zarah
Modified:
5 years, 8 months ago
Reviewers:
herhut
CC:
reviews_dartlang.org, sra1, floitsch
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

dartj2s: add constructor helpers for map literals with no type parameters. R=herhut@google.com Committed: https://code.google.com/p/dart/source/detail?r=45133

Patch Set 1 #

Patch Set 2 : Fix collection_patch. #

Patch Set 3 : Addressed comments from original issue. #

Total comments: 2

Patch Set 4 : Added comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -2 lines) Patch
M pkg/compiler/lib/src/js_backend/backend.dart View 2 chunks +19 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/ssa/builder.dart View 1 2 3 2 chunks +20 lines, -2 lines 0 comments Download
M sdk/lib/_internal/compiler/js_lib/collection_patch.dart View 1 2 1 chunk +11 lines, -0 lines 0 comments Download
M tests/compiler/dart2js/mock_libraries.dart View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
zarah
The first patch is a (rebased) copy of issue 712263002. Creating a new issue here ...
5 years, 8 months ago (2015-04-14 08:13:23 UTC) #1
zarah
5 years, 8 months ago (2015-04-14 09:53:23 UTC) #3
herhut
lgtm https://codereview.chromium.org/1051223003/diff/40001/pkg/compiler/lib/src/ssa/builder.dart File pkg/compiler/lib/src/ssa/builder.dart (right): https://codereview.chromium.org/1051223003/diff/40001/pkg/compiler/lib/src/ssa/builder.dart#newcode5664 pkg/compiler/lib/src/ssa/builder.dart:5664: if (typeInputs.every((HInstruction input) => input.isNull())) { Can you ...
5 years, 8 months ago (2015-04-14 11:00:14 UTC) #4
zarah
https://codereview.chromium.org/1051223003/diff/40001/pkg/compiler/lib/src/ssa/builder.dart File pkg/compiler/lib/src/ssa/builder.dart (right): https://codereview.chromium.org/1051223003/diff/40001/pkg/compiler/lib/src/ssa/builder.dart#newcode5664 pkg/compiler/lib/src/ssa/builder.dart:5664: if (typeInputs.every((HInstruction input) => input.isNull())) { On 2015/04/14 11:00:14, ...
5 years, 8 months ago (2015-04-14 11:27:56 UTC) #5
zarah
5 years, 8 months ago (2015-04-14 11:28:41 UTC) #6
Message was sent while issue was closed.
Committed patchset #4 (id:60001) manually as 45133 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698